shithub: libmujs

Download patch

ref: 89310461e81f069d353d4a53194c94258d9203b5
parent: 4b981faad7f0ea14ceb0af14ebfae4859fb9debb
author: Tor Andersson <[email protected]>
date: Mon Jan 13 12:21:38 EST 2014 

Optimise string interning.


--- a/jsintern.c
+++ b/jsintern.c
@@ -12,29 +12,15 @@
 
 static js_StringNode sentinel = { "", &sentinel, &sentinel, 0 };
 
-static js_StringNode *makestringnode(const char *string, const char **out)
+static js_StringNode *newstringnode(const char *string, const char **result)
 {
 	js_StringNode *node = malloc(sizeof(js_StringNode));
-	node->string = *out = strdup(string);
+	node->string = *result = strdup(string);
 	node->left = node->right = &sentinel;
 	node->level = 1;
 	return node;
 }
 
-static const char *lookup(js_StringNode *node, const char *string)
-{
-	if (node && node != &sentinel) {
-		int c = strcmp(string, node->string);
-		if (c == 0)
-			return node->string;
-		else if (c < 0)
-			return lookup(node->left, string);
-		else
-			return lookup(node->right, string);
-	}
-	return NULL;
-}
-
 static js_StringNode *skew(js_StringNode *node)
 {
 	if (node->level != 0) {
@@ -62,20 +48,21 @@
 	return node;
 }
 
-static js_StringNode *insert(js_StringNode *node, const char *string, const char **out)
+static js_StringNode *insert(js_StringNode *node, const char *string, const char **result)
 {
-	if (node && node != &sentinel) {
+	if (node != &sentinel) {
 		int c = strcmp(string, node->string);
 		if (c < 0)
-			node->left = insert(node->left, string, out);
+			node->left = insert(node->left, string, result);
+		else if (c > 0)
+			node->right = insert(node->right, string, result);
 		else
-			node->right = insert(node->right, string, out);
+			return *result = node->string, node;
 		node = skew(node);
 		node = split(node);
 		return node;
-	} else {
-		return makestringnode(string, out);
 	}
+	return newstringnode(string, result);
 }
 
 static void printstringnode(js_StringNode *node, int level)
@@ -83,9 +70,10 @@
 	int i;
 	if (node->left != &sentinel)
 		printstringnode(node->left, level + 1);
+	printf("%d: ", node->level);
 	for (i = 0; i < level; i++)
-		putchar(' ');
-	printf("'%s' (%d)\n", node->string, node->level);
+		putchar('\t');
+	printf("'%s'\n", node->string);
 	if (node->right != &sentinel)
 		printstringnode(node->right, level + 1);
 }
@@ -101,8 +89,9 @@
 
 const char *js_intern(js_State *J, const char *s)
 {
-	const char *a = lookup(J->strings, s);
-	if (!a)
-		J->strings = insert(J->strings, s, &a);
-	return a;
+	const char *result;
+	if (!J->strings)
+		J->strings = &sentinel;
+	J->strings = insert(J->strings, s, &result);
+	return result;
 }