shithub: scc

Info  •  Files  •  Log  •  Branches

cc1: Remove wrong optimization in content()

Collapsing OADDR and OPTR is a really bad idea, because
it removes the indirection operation needed.

--- a/src/cmd/cc/cc1/expr.c

+++ b/src/cmd/cc/cc1/expr.c

@@ -470,14 +470,7 @@

 	if (BTYPE(np) != PTR) {

 		errorp("invalid argument of memory indirection");

 	} else {

-		if (np->op == OADDR) {

-			Node *new = np->left;

-			new->type = np->type->type;

-			free(np);

-			np = new;

-		} else {

-			np = node(op, np->type->type, np, NULL);

-		}

+		np = node(op, np->type->type, np, NULL);

 		np->flags |= NLVAL;

 	}

 	return np;