shithub: scc

Info  •  Files  •  Log  •  Branches

[cc2] Initialize left and right pointers in constnode()

The code follows these pointers in a few cases without looking the op,
so it is better to have them initialized.

--- a/cc2/code.c

+++ b/cc2/code.c

@@ -74,8 +74,6 @@

 		sym = newlabel();

 	if (!np)

 		np = newnode(OLABEL);

-	else

-		memset(np, 0, sizeof(np));

 	np->op = OLABEL;

 	np->u.sym = sym;

@@ -87,6 +85,8 @@

 {

 	if (!np)

 		np = newnode(OCONST);

+	np->left = NULL;

+	np->right = NULL;

 	np->type = *tp;

 	np->u.i = n;

 	return np;