shithub: scc

Info  •  Files  •  Log  •  Branches

[libc] Simplify strtol* functions

Checking inside of the loop makes easier the overflow check

--- a/src/libc/stdlib/strtol.c

+++ b/src/libc/stdlib/strtol.c

@@ -46,11 +46,8 @@

 		if (-d < LONG_MIN - n)

 			goto overflow;

 		n -= d;

-	}

-

-	if (n == LONG_MIN && sign < 0) {

-		--t;

-		goto overflow;

+		if (n == LONG_MIN && sign < 0)

+			goto overflow;

 	}

 	if (end && t != s)

--- a/src/libc/stdlib/strtoll.c

+++ b/src/libc/stdlib/strtoll.c

@@ -46,11 +46,8 @@

 		if (-d < LLONG_MIN - n)

 			goto overflow;

 		n -= d;

-	}

-

-	if (n == LLONG_MIN && sign < 0) {

-		--t;

-		goto overflow;

+		if (n == LONG_MIN && sign < 0)

+			goto overflow;

 	}

 	if (end && t != s)