shithub: scc

Info  •  Files  •  Log  •  Branches

Remove realloc of cc2

These realloc was incorrect because we were storing pointers
to the buffer returned by it, so it means that in some moment
the buffer could change of size and then the pointers became
invalid. This is a first solution (simple) that can be changed
later.

--- a/cc2/parser.c

+++ b/cc2/parser.c

@@ -80,16 +80,11 @@

 static Symbol *

 parameter(char *num)

 {

-	static Symbol *tbl;

+	static Symbol tbl[NR_FUNPARAM];

 	unsigned i = atoi(num);

-	static unsigned nr;

 	if (i >= NR_FUNPARAM)

 		error(EPARNUM);

-	if (i > nr) {

-		nr = i + 50;

-		tbl = xrealloc(tbl, nr * sizeof(Symbol));

-	}

 	return &tbl[i];

 }

@@ -96,16 +91,11 @@

 static Symbol *

 local(char *num)

 {

-	static Symbol *tbl;

+	static Symbol tbl[NR_INT_IDENT];

 	unsigned i = atoi(num);

-	static unsigned nr;

 	if (i >= NR_INT_IDENT)

 		error(EINTNUM);

-	if (i > nr) {

-		nr = i + 50;

-		tbl = xrealloc(tbl, nr * sizeof(Symbol));

-	}

 	return &tbl[i];

 }

@@ -112,16 +102,12 @@

 static Symbol *

 global(char *num)

 {

-	static Symbol *tbl;

+	static Symbol tbl[NR_EXT_IDENT];

 	unsigned i = atoi(num);

-	static unsigned nr;

 	if (i >= NR_EXT_IDENT)

 		error(EEXTNUM);

-	if (i >= nr) {

-		nr = i + 50;

-		tbl = xrealloc(tbl, nr * sizeof(Symbol));

-	}

+

 	return &tbl[i];

 }