shithub: pokecrystal

Info  •  Files  •  Log  •  Branches

Fix argument handling in *coord macros. Add a "percent" shortcut.

Random returns a value from 0 to 0xff.
Instead of doing extra work, most probabilities are out of 0xff.
Convert these from percentages at build time for readability.

--- a/macros.asm

+++ b/macros.asm

@@ -13,6 +13,8 @@

 dex    EQUS "db $e8, $50" ; End a Pokedex entry.

+percent EQUS "* $ff / 100"

+

 ; macros require rst vectors to be defined

 FarCall    EQU $08

 Bankswitch EQU $10

@@ -118,15 +120,15 @@

 bccoord: MACRO

-	ld bc, TileMap + SCREEN_WIDTH * \2 + \1

+	ld bc, TileMap + SCREEN_WIDTH * (\2) + (\1)

 	ENDM

 decoord: MACRO

-	ld de, TileMap + SCREEN_WIDTH * \2 + \1

+	ld de, TileMap + SCREEN_WIDTH * (\2) + (\1)

 	ENDM

 hlcoord: MACRO

-	ld hl, TileMap + SCREEN_WIDTH * \2 + \1

+	ld hl, TileMap + SCREEN_WIDTH * (\2) + (\1)

 	ENDM