shithub: pokecrystal

Download patch

ref: d0541164589a5fd2f628bf8629f878430b31c5f7
parent: 59c95abf836e139931a41d20cf95af2472763fab
parent: 5b7773b7d3ddf1addd99588cc5c41cd81ecdc402
author: Remy Oukaour <[email protected]>
date: Fri Jan 12 12:23:50 EST 2018

Merge branch 'patch' of https://github.com/mid-kid/pokecrystal

# Conflicts:
#	constants/sprite_anim_constants.asm
#	data/sprite_anims/framesets.asm
#	data/sprite_anims/oam.asm

--- a/constants/sprite_anim_constants.asm
+++ b/constants/sprite_anim_constants.asm
@@ -116,7 +116,7 @@
 	const SPRITE_ANIM_FRAMESET_PARTY_MON_WITH_ITEM_FAST ; 06
 	const SPRITE_ANIM_FRAMESET_GS_TITLE_TRAIL           ; 07
 	const SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR        ; 08
-	const SPRITE_ANIM_FRAMESET_UNUSED_09                ; 09
+	const SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR_BIG    ; 09
 	const SPRITE_ANIM_FRAMESET_GAMEFREAK_LOGO           ; 0a
 	const SPRITE_ANIM_FRAMESET_GS_INTRO_STAR            ; 0b
 	const SPRITE_ANIM_FRAMESET_GS_INTRO_SPARKLE         ; 0c
@@ -209,7 +209,7 @@
 	const SPRITE_ANIM_OAMSET_GS_TITLE_TRAIL_1           ; 1e
 	const SPRITE_ANIM_OAMSET_GS_TITLE_TRAIL_2           ; 1f
 	const SPRITE_ANIM_OAMSET_TEXT_ENTRY_CURSOR          ; 20
-	const SPRITE_ANIM_OAMSET_FOR_UNUSED_FRAMESET_09     ; 21
+	const SPRITE_ANIM_OAMSET_TEXT_ENTRY_CURSOR_BIG      ; 21
 	const SPRITE_ANIM_OAMSET_GS_INTRO_GAMEFREAK_LOGO    ; 22
 	const SPRITE_ANIM_OAMSET_GS_INTRO_STAR              ; 23
 	const SPRITE_ANIM_OAMSET_GS_INTRO_SPARKLE_1         ; 24
--- a/constants/sprite_constants.asm
+++ b/constants/sprite_constants.asm
@@ -1,5 +1,5 @@
 ; sprite ids
-; OverworldSprites indexes (see gfx/sprite_data.asm)
+; OverworldSprites indexes (see data/sprites.asm)
 	const_def
 	const SPRITE_NONE ; 00
 	const SPRITE_CHRIS ; 01
--- a/constants/sprite_data_constants.asm
+++ b/constants/sprite_data_constants.asm
@@ -1,4 +1,4 @@
-; overworld_sprite struct members (see gfx/sprite_data.asm)
+; overworld_sprite struct members (see data/sprites.asm)
 	const_def
 	const SPRITEDATA_ADDR    ; 0
 	const SPRITEDATA_ADDR_HI ; 1
--- a/data/sprite_anims/framesets.asm
+++ b/data/sprite_anims/framesets.asm
@@ -9,7 +9,7 @@
 	dw .Frameset_PartyMonWithItemFast
 	dw .Frameset_GSTitleTrail
 	dw .Frameset_TextEntryCursor
-	dw .Frameset_Unused09
+	dw .Frameset_TextEntryCursorBig
 	dw .Frameset_GameFreakLogo
 	dw .Frameset_GSIntroStar
 	dw .Frameset_GSIntroSparkle
@@ -133,8 +133,8 @@
 	dorepeat  1
 	dorestart
 
-.Frameset_Unused09:
-	frame SPRITE_ANIM_OAMSET_FOR_UNUSED_FRAMESET_09,  1
+.Frameset_TextEntryCursorBig:
+	frame SPRITE_ANIM_OAMSET_TEXT_ENTRY_CURSOR_BIG,  1
 	dorepeat  1
 	dorestart
 
--- a/data/sprite_anims/oam.asm
+++ b/data/sprite_anims/oam.asm
@@ -34,7 +34,7 @@
 	dbw $f8, .OAMData_GSTitleTrail             ; SPRITE_ANIM_OAMSET_GS_TITLE_TRAIL_1
 	dbw $fa, .OAMData_GSTitleTrail             ; SPRITE_ANIM_OAMSET_GS_TITLE_TRAIL_2
 	dbw $00, .OAMData_TextEntryCursor          ; SPRITE_ANIM_OAMSET_TEXT_ENTRY_CURSOR
-	dbw $00, .OAMData_ForUnusedFrameset09      ; SPRITE_ANIM_OAMSET_FOR_UNUSED_FRAMESET_09
+	dbw $00, .OAMData_TextEntryCursorBig       ; SPRITE_ANIM_OAMSET_TEXT_ENTRY_CURSOR_BIG
 	dbw $00, .OAMData_GSIntroGameFreakLogo     ; SPRITE_ANIM_OAMSET_GS_INTRO_GAMEFREAK_LOGO
 	dbw $0f, .OAMData_GSIntroStar              ; SPRITE_ANIM_OAMSET_GS_INTRO_STAR
 	dbw $11, .OAMData_1x1_Palette0             ; SPRITE_ANIM_OAMSET_GS_INTRO_SPARKLE_1
@@ -458,7 +458,7 @@
 	dsprite  0,  0, -1,  7, $00, 0 | Y_FLIP
 	dsprite  0,  0,  0,  0, $00, 0 | X_FLIP | Y_FLIP
 
-.OAMData_ForUnusedFrameset09:
+.OAMData_TextEntryCursorBig:
 	db 10
 	dsprite -1,  7,  0,  0, $00, 0
 	dsprite -1,  7,  1,  0, $01, 0
--- a/engine/namingscreen.asm
+++ b/engine/namingscreen.asm
@@ -568,14 +568,14 @@
 .ok
 	cp d
 	ld de, .LetterEntries
-	ld a, $0
+	ld a, SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR - SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR ; 0
 	jr nz, .ok2
 	ld de, .CaseDelEnd
-	ld a, $1
+	ld a, SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR_BIG - SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR ; 1
 .ok2
 	ld hl, SPRITEANIMSTRUCT_0E
 	add hl, bc
-	add [hl]
+	add [hl] ; default SPRITE_ANIM_FRAMESET_TEXT_ENTRY_CURSOR
 	ld hl, SPRITEANIMSTRUCT_FRAMESET_ID
 	add hl, bc
 	ld [hl], a