shithub: riscv

Info  •  Files  •  Log  •  Branches

git: fully init objq

we were leaving objq.best uninitialized, and
would therefore read garbage if we didn't
find a best match.

--- a/sys/src/cmd/git/ref.c

+++ b/sys/src/cmd/git/ref.c

@@ -217,6 +217,7 @@

 	osinit(&keep);

 	osinit(&drop);

+	memset(&objq, 0, sizeof(objq));

 	qinit(&objq);

 	objq.head = head;

 	objq.nhead = nhead;

@@ -335,9 +336,9 @@

 	if(paint(&a->hash, 1, &b->hash, 1, &o, &n, 1) == -1 || n == 0)

 		return nil;

-	r = o[0];

+	r = ref(o[0]);

 	free(o);

-	return ref(r);

+	return r;

 }

 int