shithub: riscv

Info  •  Files  •  Log  •  Branches

ref: check if object is a commit when needed

--- a/sys/src/cmd/git/ref.c

+++ b/sys/src/cmd/git/ref.c

@@ -188,6 +188,10 @@

 			break;

 		}

 		o = readobject(e.o->hash);

+		if(o->type != GCommit){

+			werrstr("not a commit: %H", o->hash);

+			goto error;

+		}

 		for(i = 0; i < o->commit->nparent; i++){

 			if((c = readobject(e.o->commit->parent[i])) == nil)

 				goto error;

@@ -305,6 +309,10 @@

 	Object *o, *p;

 	o = pop(ev);

+	if(o->type != GCommit){

+		werrstr("not a commit: %H", o->hash);

+		return -1;

+	}

 	/* Special case: first commit has no parent. */

 	if(o->commit->nparent == 0)

 		p = emptydir();