ref: 95524b1cdd24091d8d677d4c7a0bb8492f1a7961
parent: de1e74abd21007b75e456a7810f923a5043ada87
author: cinap_lenrek <[email protected]>
date: Fri Jul 15 17:13:35 EDT 2016
5c: fix int -> uvlong cast bug (thanks to qwx on his patience on a the trouble session to narrowing it down)
we used to not sign extend if the destination was unsigned
uvlong, which is wrong. we have to sign extend only based
on the signedness of the source (it gets propagated to vlong)
this bug hit in hjfs in the newentry() function, causing file
creation to fail with "create -- phase error":
newentry(...)
{
uvlong sj;
int si;
...
sj = si = -1;
...
}
--- a/sys/src/cmd/5c/cgen.c
+++ b/sys/src/cmd/5c/cgen.c
@@ -961,7 +961,7 @@
reg[nn->right->reg] = 0;
cgen(l, &nod1);
reg[nn->right->reg] = a;
- if(typeu[n->type->etype] || typeu[l->type->etype])
+ if(typeu[l->type->etype])
gmove(nodconst(0), nn->right);
else
gopcode(OASHR, nodconst(31), &nod1, nn->right);