shithub: opusfile

Download patch

ref: 2521a7d81c40ea83e568a7085e717228932832a3
parent: c59d42b6fb4bb2b7e8c7debfa816e2641fd998b6
author: Timothy B. Terriberry <[email protected]>
date: Tue Aug 1 12:49:32 EDT 2017

Print a useful error when pkg-config is missing

Without this check, the PKG_CHECK_MODULES() macro remains
unexpanded, which gives a syntax error when the shell reaches that
point in the configure script, even for checks which are disabled
(e.g., the OpenSSL check when using --disable-http).

Instead, explicitly check for pkg-config and give the user useful
advice on how to solve the problem if it's not found.

Thanks to eXpl0it3r for reporting a problem for which installing
pkg-config turned out to be the solution.

--- a/configure.ac
+++ b/configure.ac
@@ -88,6 +88,11 @@
 )
 AC_SEARCH_LIBS(ftime, [compat], , [enable_http=no])
 
+m4_ifndef([PKG_PROG_PKG_CONFIG],
+  [m4_fatal([Could not locate the pkg-config autoconf macros.
+Please make sure pkg-config is installed and, if necessary, set the environment
+variable ACLOCAL="aclocal -I/path/to/pkg.m4".])])
+
 AS_IF([test "$enable_http" != "no"], [
    openssl="openssl"
    AC_DEFINE([OP_ENABLE_HTTP], [1], [Enable HTTP support])