shithub: aacdec

Info  •  Files  •  Log  •  Branches

main: fix crash with unsupported MP4 files

aac_frame_decode returns NULL on failure.

decodeMP4file should consequently NULL-check NeAACDecDecode's return
pointer before doing anything with it. Not doing so leads to undefined
behavior (division by zero, NULL pointer dereference, etc.)

add missing NULL-check.

fixes #13.

--- a/frontend/main.c

+++ b/frontend/main.c

@@ -915,6 +915,11 @@

         sample_buffer = NeAACDecDecode(hDecoder, &frameInfo, mp4config.bitbuf.data, mp4config.bitbuf.size);

+        if (!sample_buffer) {

+            /* unable to decode file, abort */

+            break;

+        }

+

         if (adts_out == 1)

         {

             adtsData = MakeAdtsHeader(&adtsDataSize, &frameInfo, 0);

@@ -1365,4 +1370,4 @@

 #else

     return faad_main(argc, argv);

 #endif

-}

\ No newline at end of file

+}