shithub: dumb

Info  •  Files  •  Log  •  Branches

- I didn't realize that sigrenderer->tick counted down from speed to 1, rather
  than up from 0 to speed-1, so every other format's arpeggios were backwards
  except for XM. Fixed.
- Mask tick count to 0-31 so it can't overflow the arpeggio tables.

--- a/dumb/src/it/itrender.c

+++ b/dumb/src/it/itrender.c

@@ -4186,10 +4186,10 @@

 				}

 				else*/

 				{

-					int tick = sigrenderer->tick;

-					if ((sigrenderer->sigdata->flags & (IT_WAS_AN_XM|IT_WAS_A_MOD))==IT_WAS_AN_XM)

+					int tick = sigrenderer->tick - 1;

+					if ((sigrenderer->sigdata->flags & (IT_WAS_AN_XM|IT_WAS_A_MOD))!=IT_WAS_AN_XM)

 						tick = sigrenderer->speed - tick - 1;

-					playing->delta *= (float)pow(DUMB_SEMITONE_BASE, channel->arpeggio_offsets[channel->arpeggio_table[tick]]);

+					playing->delta *= (float)pow(DUMB_SEMITONE_BASE, channel->arpeggio_offsets[channel->arpeggio_table[tick&31]]);

 				}

 			/*

 			}*/