shithub: libvpx

Info  •  Files  •  Log  •  Branches

mips: clean up wextra warnings

Remove unused zbin variable:
warning: unused parameter ‘zbin’

Use int for loop variables to avoid unsigned conversion:
warning: comparison between signed and unsigned integer expressions

Change-Id: Icea74b870c0ee68a8bf687e796a69392af25a8ad

--- a/vp8/encoder/mips/msa/quantize_msa.c

+++ b/vp8/encoder/mips/msa/quantize_msa.c

@@ -12,10 +12,9 @@

 #include "vp8/common/mips/msa/vp8_macros_msa.h"

 #include "vp8/encoder/block.h"

-static int8_t fast_quantize_b_msa(int16_t *coeff_ptr, int16_t *zbin,

-                                  int16_t *round, int16_t *quant,

-                                  int16_t *de_quant, int16_t *q_coeff,

-                                  int16_t *dq_coeff) {

+static int8_t fast_quantize_b_msa(int16_t *coeff_ptr, int16_t *round,

+                                  int16_t *quant, int16_t *de_quant,

+                                  int16_t *q_coeff, int16_t *dq_coeff) {

   int32_t cnt, eob;

   v16i8 inv_zig_zag = { 0, 1, 5, 6, 2, 4, 7, 12, 3, 8, 11, 13, 9, 10, 14, 15 };

   v8i16 round0, round1;

@@ -184,7 +183,6 @@

 void vp8_fast_quantize_b_msa(BLOCK *b, BLOCKD *d) {

   int16_t *coeff_ptr = b->coeff;

-  int16_t *zbin_ptr = b->zbin;

   int16_t *round_ptr = b->round;

   int16_t *quant_ptr = b->quant_fast;

   int16_t *qcoeff_ptr = d->qcoeff;

@@ -191,8 +189,8 @@

   int16_t *dqcoeff_ptr = d->dqcoeff;

   int16_t *dequant_ptr = d->dequant;

-  *d->eob = fast_quantize_b_msa(coeff_ptr, zbin_ptr, round_ptr, quant_ptr,

-                                dequant_ptr, qcoeff_ptr, dqcoeff_ptr);

+  *d->eob = fast_quantize_b_msa(coeff_ptr, round_ptr, quant_ptr, dequant_ptr,

+                                qcoeff_ptr, dqcoeff_ptr);

 }

 void vp8_regular_quantize_b_msa(BLOCK *b, BLOCKD *d) {

--- a/vpx_dsp/mips/add_noise_msa.c

+++ b/vpx_dsp/mips/add_noise_msa.c

@@ -14,7 +14,7 @@

 void vpx_plane_add_noise_msa(uint8_t *start_ptr, const int8_t *noise,

                              int blackclamp, int whiteclamp, int width,

                              int height, int32_t pitch) {

-  uint32_t i, j;

+  int i, j;

   for (i = 0; i < height / 2; ++i) {

     uint8_t *pos0_ptr = start_ptr + (2 * i) * pitch;