shithub: libvpx

Download patch

ref: 0966757874c4555d0e781362389711dfe6e9aec7
parent: 7d2690e658b1ace33a659e18c895c9cf1745f33f
author: Jerome Jiang <[email protected]>
date: Tue Nov 22 08:35:12 EST 2016 

Cosmetic changes to post proc unit tests.

Remove unnecessary "virtual" before some functions. Change *_btm_* in
variable names to *_bottom_*.

Change-Id: Ifd4ce667537617f451cdfed47dd8c48817fd983b


--- a/test/pp_filter_test.cc
+++ b/test/pp_filter_test.cc
@@ -168,7 +168,7 @@
   virtual void TearDown() { libvpx_test::ClearSystemState(); }
 
  protected:
-  virtual void SetRows(unsigned char *src_c, int rows, int cols) {
+  void SetRows(unsigned char *src_c, int rows, int cols) {
     for (int r = 0; r < rows; r++) {
       memset(src_c, r, cols);
       src_c += cols;
@@ -175,8 +175,8 @@
     }
   }
 
-  virtual void SetRandom(unsigned char *src_c, unsigned char *src_asm, int rows,
-                         int cols, int src_pitch) {
+  void SetRandom(unsigned char *src_c, unsigned char *src_asm, int rows,
+                 int cols, int src_pitch) {
     ACMRandom rnd;
     rnd.Reset(ACMRandom::DeterministicSeed());
 
@@ -192,8 +192,8 @@
     }
   }
 
-  virtual void SetRandomSaturation(unsigned char *src_c, unsigned char *src_asm,
-                                   int rows, int cols, int src_pitch) {
+  void SetRandomSaturation(unsigned char *src_c, unsigned char *src_asm,
+                           int rows, int cols, int src_pitch) {
     ACMRandom rnd;
     rnd.Reset(ACMRandom::DeterministicSeed());
 
@@ -209,9 +209,8 @@
     }
   }
 
-  virtual void RunComparison(const unsigned char *kExpectedOutput,
-                             unsigned char *src_c, int rows, int cols,
-                             int src_pitch) {
+  void RunComparison(const unsigned char *kExpectedOutput, unsigned char *src_c,
+                     int rows, int cols, int src_pitch) {
     for (int r = 0; r < rows; r++) {
       for (int c = 0; c < cols; c++) {
         ASSERT_EQ(kExpectedOutput[r * rows + c], src_c[c]) << "at (" << r
@@ -221,8 +220,8 @@
     }
   }
 
-  virtual void RunComparison(unsigned char *src_c, unsigned char *src_asm,
-                             int rows, int cols, int src_pitch) {
+  void RunComparison(unsigned char *src_c, unsigned char *src_asm, int rows,
+                     int cols, int src_pitch) {
     for (int r = 0; r < rows; r++) {
       for (int c = 0; c < cols; c++) {
         ASSERT_EQ(src_c[c], src_asm[c]) << "at (" << r << ", " << c << ")";
@@ -238,9 +237,9 @@
   const int cols = 16;
   const int src_pitch = cols;
   const int src_top_padding = 8;
-  const int src_btm_padding = 17;
+  const int src_bottom_padding = 17;
 
-  const int src_size = cols * (rows + src_top_padding + src_btm_padding);
+  const int src_size = cols * (rows + src_top_padding + src_bottom_padding);
   unsigned char *c_mem = new unsigned char[src_size];
   ASSERT_TRUE(c_mem != NULL);
   memset(c_mem, 10, src_size);
@@ -277,8 +276,8 @@
   const int cols = 16;
   const int src_pitch = cols;
   const int src_top_padding = 8;
-  const int src_btm_padding = 17;
-  const int src_size = cols * (rows + src_top_padding + src_btm_padding);
+  const int src_bottom_padding = 17;
+  const int src_size = cols * (rows + src_top_padding + src_bottom_padding);
   unsigned char *c_mem = new unsigned char[src_size];
   unsigned char *asm_mem = new unsigned char[src_size];
   memset(c_mem, 10, src_size);