shithub: libvpx

Info  •  Files  •  Log  •  Branches

vp8: enc: Fix valid range for under/over_shoot pct

The overshoot_pct & undershoot_pct attributes for rate control
are expressed as a percentage of the target bitrate, so the range
should be 0-100.

Change-Id: I67af3c8be7ab814c711c2eaf30786f1e2fa4f5a3

--- a/vp8/vp8_cx_iface.c

+++ b/vp8/vp8_cx_iface.c

@@ -152,8 +152,8 @@

   RANGE_CHECK_HI(cfg, g_lag_in_frames, 25);

 #endif

   RANGE_CHECK(cfg, rc_end_usage, VPX_VBR, VPX_Q);

-  RANGE_CHECK_HI(cfg, rc_undershoot_pct, 1000);

-  RANGE_CHECK_HI(cfg, rc_overshoot_pct, 1000);

+  RANGE_CHECK_HI(cfg, rc_undershoot_pct, 100);

+  RANGE_CHECK_HI(cfg, rc_overshoot_pct, 100);

   RANGE_CHECK_HI(cfg, rc_2pass_vbr_bias_pct, 100);

   RANGE_CHECK(cfg, kf_mode, VPX_KF_DISABLED, VPX_KF_AUTO);

--- a/vpx/vpx_encoder.h

+++ b/vpx/vpx_encoder.h

@@ -498,7 +498,7 @@

    * undershoot level (current rate vs target) beyond which more aggressive

    * corrective measures are taken.

    *   *

-   * Valid values in the range VP8:0-1000 VP9: 0-100.

+   * Valid values in the range VP8:0-100 VP9: 0-100.

    */

   unsigned int rc_undershoot_pct;

@@ -513,7 +513,7 @@

    * overshoot level (current rate vs target) beyond which more aggressive

    * corrective measures are taken.

    *

-   * Valid values in the range VP8:0-1000 VP9: 0-100.

+   * Valid values in the range VP8:0-100 VP9: 0-100.

    */

   unsigned int rc_overshoot_pct;