shithub: libvpx

Download patch

ref: c782f27ead354ae7fa4a40c5c679071ae9e8dd3b
parent: 4702bb26be21d4a9ec129c89e711ebf79265033e
author: Johann <[email protected]>
date: Wed Jul 19 10:20:13 EDT 2017

quantize test: lowbd functions do not pass in highbd

qcoeff output looks OK but dqcoeff is no good.

BUG=webm:1448

Change-Id: I07211db8a8b74f1f45fdd059852e2de0e5ee18fd

--- a/test/vp9_quantize_test.cc
+++ b/test/vp9_quantize_test.cc
@@ -353,11 +353,11 @@
 
 #if HAVE_SSE2
 #if CONFIG_VP9_HIGHBITDEPTH
+// TODO(johannkoenig): Fix vpx_quantize_b_sse2 in highbitdepth builds.
+// make_tuple(&vpx_quantize_b_sse2, &vpx_highbd_quantize_b_c, VPX_BITS_8),
 INSTANTIATE_TEST_CASE_P(
     SSE2, VP9QuantizeTest,
-    ::testing::Values(make_tuple(&vpx_quantize_b_sse2, &vpx_highbd_quantize_b_c,
-                                 VPX_BITS_8),
-                      make_tuple(&vpx_highbd_quantize_b_sse2,
+    ::testing::Values(make_tuple(&vpx_highbd_quantize_b_sse2,
                                  &vpx_highbd_quantize_b_c, VPX_BITS_8),
                       make_tuple(&vpx_highbd_quantize_b_sse2,
                                  &vpx_highbd_quantize_b_c, VPX_BITS_10),
@@ -392,8 +392,9 @@
                                  &vpx_quantize_b_32x32_c, VPX_BITS_8)));
 #endif  // HAVE_SSSE3 && ARCH_X86_64
 
-// TODO(johannkoenig): AVX optimizations do not yet pass the 32x32 test.
-#if HAVE_AVX && ARCH_X86_64
+// TODO(johannkoenig): AVX optimizations do not yet pass the 32x32 test or
+// highbitdepth configurations.
+#if HAVE_AVX && ARCH_X86_64 && !CONFIG_VP9_HIGHBITDEPTH
 INSTANTIATE_TEST_CASE_P(AVX, VP9QuantizeTest,
                         ::testing::Values(make_tuple(&vpx_quantize_b_avx,
                                                      &vpx_quantize_b_c,
@@ -403,5 +404,5 @@
                         ::testing::Values(make_tuple(&vpx_quantize_b_32x32_avx,
                                                      &vpx_quantize_b_32x32_c,
                                                      VPX_BITS_8)));
-#endif  // HAVE_AVX && ARCH_X86_64
+#endif  // HAVE_AVX && ARCH_X86_64 && !CONFIG_VP9_HIGHBITDEPTH
 }  // namespace