shithub: libvpx

Info  •  Files  •  Log  •  Branches

{highbd_,}loopfilter_neon.c: quiet -Wmaybe-uninitialized

Seen with arm-linux-gnueabihf-gcc-8 (8.3.0 & 8.4.0)

Without reworking the code or adding an additional branch this warning
cannot be silenced otherwise. The loopfilter is only called when needed
for a block so these output pixels will be set.

BUG=b/176822719

Change-Id: I9cf6e59bd5de901e168867ccbe021d28d0c04933

--- a/vpx_dsp/arm/highbd_loopfilter_neon.c

+++ b/vpx_dsp/arm/highbd_loopfilter_neon.c

@@ -661,6 +661,17 @@

   vpx_highbd_lpf_vertical_8_neon(s + 8 * p, p, blimit1, limit1, thresh1, bd);

 }

+// Quiet warnings of the form: 'vpx_dsp/arm/highbd_loopfilter_neon.c|675 col 67|

+// warning: 'oq1' may be used uninitialized in this function

+// [-Wmaybe-uninitialized]', for oq1-op1. Without reworking the code or adding

+// an additional branch this warning cannot be silenced otherwise. The

+// loopfilter is only called when needed for a block so these output pixels

+// will be set.

+#if defined(__GNUC__) && __GNUC__ >= 4 && !defined(__clang__)

+#pragma GCC diagnostic push

+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"

+#endif

+

 static void lpf_horizontal_16_kernel(uint16_t *s, int p,

                                      const uint16x8_t blimit_vec,

                                      const uint16x8_t limit_vec,

@@ -722,6 +733,10 @@

     store_4x8(s - 2, p, op1, op0, oq0, oq1);

   }

 }

+

+#if defined(__GNUC__) && __GNUC__ >= 4 && !defined(__clang__)

+#pragma GCC diagnostic pop

+#endif

 void vpx_highbd_lpf_horizontal_16_neon(uint16_t *s, int p,

                                        const uint8_t *blimit,

--- a/vpx_dsp/arm/loopfilter_neon.c

+++ b/vpx_dsp/arm/loopfilter_neon.c

@@ -975,6 +975,17 @@

 FUN_LPF_16_KERNEL(_dual_, 16)  // lpf_16_dual_kernel

 #undef FUN_LPF_16_KERNEL

+// Quiet warnings of the form: 'vpx_dsp/arm/loopfilter_neon.c|981 col 42|

+// warning: 'oq1' may be used uninitialized in this function

+// [-Wmaybe-uninitialized]', for oq1-op1. Without reworking the code or adding

+// an additional branch this warning cannot be silenced otherwise. The

+// loopfilter is only called when needed for a block so these output pixels

+// will be set.

+#if defined(__GNUC__) && __GNUC__ >= 4 && !defined(__clang__)

+#pragma GCC diagnostic push

+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"

+#endif

+

 void vpx_lpf_horizontal_16_neon(uint8_t *s, int p, const uint8_t *blimit,

                                 const uint8_t *limit, const uint8_t *thresh) {

   uint8x8_t p7, p6, p5, p4, p3, p2, p1, p0, q0, q1, q2, q3, q4, q5, q6, q7, op6,

@@ -1090,3 +1101,7 @@

               vget_high_u8(oq0), vget_high_u8(oq1));

   }

 }

+

+#if defined(__GNUC__) && __GNUC__ >= 4 && !defined(__clang__)

+#pragma GCC diagnostic pop

+#endif