shithub: openh264

Info  •  Files  •  Log  •  Branches

Respect the loop filter disabling encoder parameter

Previously the loop filter was unconditionally enabled
regardless of what encoder parameter was set. If using
SEncParamBase instead, the loop filter was always disabled.

--- a/codec/encoder/core/inc/param_svc.h

+++ b/codec/encoder/core/inc/param_svc.h

@@ -302,10 +302,10 @@

   SUsedPicRect.iHeight = ((iPicHeight >> 1) << 1);

   /* Deblocking loop filter */

+  iLoopFilterDisableIdc	= pCodingParam.iLoopFilterDisableIdc;	// 0: on, 1: off, 2: on except for slice boundaries,

 #ifdef MT_ENABLED

-  iLoopFilterDisableIdc	= 2;//pCodingParam.iLoopFilterDisableIdc;	// 0: on, 1: off, 2: on except for slice boundaries,

-#else

-  iLoopFilterDisableIdc	= 0;	// 0: on, 1: off, 2: on except for slice boundaries

+  if (iLoopFilterDisableIdc == 0) // Loop filter requested to be enabled

+    iLoopFilterDisableIdc = 2; // Disable loop filter on slice boundaries since that's not possible with multithreading

 #endif

   iLoopFilterAlphaC0Offset = 0;	// AlphaOffset: valid range [-6, 6], default 0

   iLoopFilterBetaOffset	= 0;	// BetaOffset:	valid range [-6, 6], default 0