shithub: openh264

Download patch

ref: 2907cb2875354bb8e36633cf61d7654fa7554f3e
parent: a625dc836d8d9c60cd1c9305a1c842f5fcbcacb1
author: Martin Storsjö <[email protected]>
date: Wed Oct 29 16:29:43 EDT 2014

Remove an impossible condition

uiIntraPeriod is unsigned, and thus can't ever be negative.

The subtraction on the line above can't ever make the value wrap
around either, since param_.uiIntraPeriod % uiGOPSize always is
smaller than or equal to param_.uiIntraPeriod. Thus, the check
never is necessary even if the value would be signed either.

This fixes warnings when building with clang.

--- a/test/api/encode_decode_api_test.cpp

+++ b/test/api/encode_decode_api_test.cpp

@@ -282,9 +282,6 @@

   //IntraPeriod

   uiGOPSize = 1 << (param_.iTemporalLayerNum - 1);

   param_.uiIntraPeriod -= param_.uiIntraPeriod % uiGOPSize;

-  if (param_.uiIntraPeriod < 0) {

-    param_.uiIntraPeriod = 0;

-  }

 //RefNum

   int32_t iRefUpperBound    = (param_.iUsageType == CAMERA_VIDEO_REAL_TIME) ?