shithub: openh264

Download patch

ref: fb5e508e64f47d9cc8289277134a302853a58a0f
parent: 234f70988fff844bf64e1242482cf9a7431b8060
author: Martin Storsjö <[email protected]>
date: Fri Sep 25 05:32:31 EDT 2020 

Use the right thread function signature in WealThreadPoolTest

This fixes warnings when built with clang for i686, warning about
casting between cdecl and stdcall - which normally can be fatal.

This avoids needing to use casts when passing the function to
WelsThreadCreate across all platforms.


--- a/test/common/WelsThreadPoolTest.cpp
+++ b/test/common/WelsThreadPoolTest.cpp
@@ -14,7 +14,7 @@
 
 uint32_t CSimpleTask::id = 0;
 
-void* OneCallingFunc() {
+WELS_THREAD_ROUTINE_TYPE OneCallingFunc(void *) {
   CThreadPoolTest cThreadPoolTest;
   CSimpleTask* aTasks[TEST_TASK_NUM];
   CWelsThreadPool* pThreadPool = (CWelsThreadPool::AddReference());
@@ -44,7 +44,7 @@
 
 
 TEST (CThreadPoolTest, CThreadPoolTest) {
-  OneCallingFunc();
+  OneCallingFunc(NULL);
 
   int iRet = CWelsThreadPool::SetThreadNum (8);
   EXPECT_EQ (0, iRet);
@@ -81,12 +81,12 @@
   int i = 0;
   WELS_THREAD_ERROR_CODE rc;
   for (i = 0; i < iCallingNum; i++) {
-    rc = WelsThreadCreate (& (mThreadID[i]), (LPWELS_THREAD_ROUTINE)OneCallingFunc, NULL, 0);
+    rc = WelsThreadCreate (& (mThreadID[i]), OneCallingFunc, NULL, 0);
     ASSERT_TRUE (rc == WELS_THREAD_ERROR_OK);
     WelsSleep (1);
   }
   for (i = iCallingNum; i < iCallingNum * 2; i++) {
-    rc = WelsThreadCreate (& (mThreadID[i]), (LPWELS_THREAD_ROUTINE)OneCallingFunc, NULL, 0);
+    rc = WelsThreadCreate (& (mThreadID[i]), OneCallingFunc, NULL, 0);
     ASSERT_TRUE (rc == WELS_THREAD_ERROR_OK);
     WelsSleep (1);
     WelsThreadJoin (mThreadID[i]);
@@ -95,7 +95,7 @@
     WelsThreadJoin (mThreadID[i]);
   }
   for (i = iCallingNum * 2; i < iCallingNum * 3; i++) {
-    rc = WelsThreadCreate (& (mThreadID[i]), (LPWELS_THREAD_ROUTINE)OneCallingFunc, NULL, 0);
+    rc = WelsThreadCreate (& (mThreadID[i]), OneCallingFunc, NULL, 0);
     ASSERT_TRUE (rc == WELS_THREAD_ERROR_OK);
     WelsSleep (1);
     WelsThreadJoin (mThreadID[i]);